Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAT-7937: add returntype to definitions table #412

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

MAT-7937: add returntype to definitions table #412

wants to merge 4 commits into from

Conversation

ethankaplan
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7937
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@ethankaplan ethankaplan marked this pull request as ready for review December 17, 2024 18:22
@ethankaplan ethankaplan requested a review from a team as a code owner December 17, 2024 18:22
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (d7eab50) to head (078270b).

Files with missing lines Patch % Lines
...nel/definitionsSection/definitions/Definitions.tsx 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #412      +/-   ##
===========================================
+ Coverage    89.75%   89.76%   +0.01%     
===========================================
  Files           74       74              
  Lines         1922     1925       +3     
  Branches       347      348       +1     
===========================================
+ Hits          1725     1728       +3     
  Misses         131      131              
  Partials        66       66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RohitKandimalla RohitKandimalla RohitKandimalla left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethankaplan @RohitKandimalla